-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support OTel 0.25 & 0.26 #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Is this okay to be merged and released soon? |
Added support for 0.26 as well, now |
Ping @eopb 🙂 |
conradludgate
approved these changes
Oct 16, 2024
eopb
approved these changes
Oct 16, 2024
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
Thanks for merging! Any chance for a release as well? 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that open-telemetry/opentelemetry-rust#2040 removed custom
writer
support fromopentelemetry-stdout
, so I didn't add that to the tests. Not sure what its purpose is since it only usesstd::io::sink()
anyways?